Fix CheckboxGroup tests to use process.nextTick() #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| expect(component.state().value).to.eql({ terminator: false, predator: true, soundofmusic: false }); | ||
| process.nextTick(() => { | ||
| expect(component.state().value).to.eql({ terminator: false, predator: true, soundofmusic: false }); | ||
| }); |
There was a problem hiding this comment.
you need to pass in done() to ensure that the test will finish after nextTick() is executed
There was a problem hiding this comment.
When I do that, the test fails... go figure.
omgaz
reviewed
May 28, 2018
| @@ -64,7 +65,9 @@ describe('CheckboxGroup', () => { | |||
| ); | |||
| const firstChild = component.find('Checkbox').at(0); | |||
| firstChild.simulate('change', event); | |||
| expect(component.state().value).to.eql({ terminator: true, predator: false, soundofmusic: false }); | |||
| process.nextTick(() => { | |||
There was a problem hiding this comment.
I feel like this is a good retro learned to add and talk about
There was a problem hiding this comment.
Yeah, once we're sure what we've learned... so far it's all very weird. Multiple discussions on github but no resolution that works, at least, not for our use case:
- Component State doesn't update on simulating input change event enzymejs/enzyme#1283
- How to : Simulate the click event of child component in parent component enzymejs/enzyme#382
- Listening to renders enzymejs/enzyme#728
- mount/shallow does not rerender when props change or apply new props on update enzymejs/enzyme#1229
- simulate('click') on child component does not propagate to trigger blur on parent enzymejs/enzyme#1551
|
Closing this PR as none of us had any luck finding out what the problem was. It was decided to drop node v6 support instead, see #722. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix CheckboxGroup tests to use process.nextTick() to ensure that state is updated.
Description
Motivation and Background Context
For some reason, the tests were passing on node v8, failing on node 6.14.2.
Does this PR introduce a breaking change?
How Has This Been Tested?
Screenshots (if appropriate):
Check-list: